Skip to content

feat: easy localstack integration #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: easy localstack integration #148

wants to merge 1 commit into from

Conversation

@aleslash
Copy link

Issue #, if available:

Description of changes:
Made possible to use this helm chart with localstack for easy local development.
In order to run ack with localstack and kind you need to configure ack controller to have the identity_endpoint_url set to sts in localstack and enable the allow_unsafe_aws_endpoint_urls.
Without this PR it is impossible to use the original chart.

The chart now has two new optional parameters that enable this integration locally in kind environment.
The deployment manifest now also have this optional parameters.

So, when applying the new helm chart, you can use this:

helm upgrade --install --force ack-dynamodb-controller --namespace ack-system --set aws.endpoint_url=http://localhost:4566 --set aws.identity_endpoint_url=http://localhost:4566 --set aws.credentials.secretName=xxx --set aws.allow_unsafe_aws_endpoint_urls=true --create-namespace ack/dynamodb-chart

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
Copy link

ack-prow bot commented Sep 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aleslash
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler September 19, 2025 23:09
@ack-prow
Copy link

ack-prow bot commented Sep 19, 2025

Hi @aleslash. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

@jlbutler jlbutler Awaiting requested review from jlbutler

Assignees

No one assigned

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aleslash